Multiplatform #520
Merged
Multiplatform #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TShapinsky
force-pushed
the
multiplatform
branch
from
b9062b2
to
5a469b0
Compare
anyaelena
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
is this just cleanup of unnecessary dependencies post the move to model-specific python dependency files a while back?
There was a problem hiding this comment.
After moving to 3.10 we didn't need imporlib-metadata anymore and because the python installs are now split symfit moved to 3.8. I think upgrading to 3.10 also allowed the matplotlib pinning to be skipped. It's still installed though, just though a different dependency.
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Set up QEMU |
There was a problem hiding this comment.
can i get a quick update on what QEMU is doing?
|
QEMU is required in order to build the arm64 image. Eventually we might be
able to do the build on an arm64 worker, but for now it's emulated
…On Tue, Aug 6, 2024, 06:43 Anya Petersen ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
On pyproject.toml
<#520 (comment)>:
is this just cleanup of unnecessary dependencies post the move to
model-specific python dependency files a while back?
------------------------------
In .github/workflows/ci.yml
<#520 (comment)>:
> with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
+ - name: Set up QEMU
can i get a quick update on what QEMU is doing?
—
Reply to this email directly, view it on GitHub
<#520 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDNI6O5TJEXWY7XYMTCIVTZQDAIFAVCNFSM6AAAAABLQ4CGACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRRGE4DQMJWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alfalfa-dependencieslinux/amd64andlinux/arm64Size can be shrunk further by removing pre-installed python 3.8 dependencies which are just there to make the
refrig-casetest run faster. If we used this test less we could remove those as default installed dependencies and reduce the size by another ~400MB.